Issue 10908007: Add test for final field initialization (fails on the VM).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908007: Add test for final field initialization (fails on the VM). (Closed)

Created:
8 years, 3 months ago by kasperl

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray, hausner

CC:
reviews_dartlang.org, hausner, gbracha

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test for final field initialization (fails on the VM). R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11593

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -16 lines)			Patch
M	tests/language/field_initialization_order_test.dart	View	2 chunks	+11 lines, -5 lines	0 comments	Download
A +	tests/language/final_field_initialization_order_test.dart	View	5 chunks	+17 lines, -10 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

8 years, 3 months ago (2012-08-30 15:44:29 UTC) #3

DBC

final_field_initialization_order_test.dart is wrong in my opinion. Final fields
can only be initialized once. If there is a field initializer at the point of
declaration, there cannot be a second one in the constructor's initializer list.

Please clarify with Gilad. The above semantics is what he and I discussed when I
implemented this in the VM.

Expand Messages | Collapse Messages