Issue 10907064: Fix argument definition test (issue 4888).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907064: Fix argument definition test (issue 4888). (Closed)

Created:
8 years, 3 months ago by regis

Modified:
8 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix argument definition test (issue 4888). Committed: https://code.google.com/p/dart/source/detail?r=11835

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -21 lines)			Patch
M	runtime/vm/parser.cc	View	1	2 chunks	+7 lines, -15 lines	0 comments	Download
M	runtime/vm/scopes.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

regis

Delicate code ;-) Some asserts were too strict and function level was incorrect for outer ...

8 years, 3 months ago (2012-09-04 18:43:43 UTC) #1

regis

8 years, 3 months ago (2012-09-04 18:59:18 UTC) #3

On 2012/09/04 18:49:02, hausner wrote:
> Delicate indeed. LGTM.

Thanks!