Use onClosed instead of onError in the WebSocket classes.

Use onClosed instead of onError in the WebSocket classes.

There is a remaining onerror in 'class WebSocket', but as it's
documented (though unused in the spec), we've left it in for
completeness.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11785

[Anders Johnsen, 2012-09-03 14:30:08]

Maybe, most importantly, this fixes default values for close code and reason.

[Søren Gjesse, 2012-09-04 07:17:10]

lgtm

https://chromiumcodereview.appspot.com/10907047/diff/1/runtime/bin/websocket_...
File runtime/bin/websocket_impl.dart (right):

https://chromiumcodereview.appspot.com/10907047/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:220: } catch (e, s) {
Are you using s?

https://chromiumcodereview.appspot.com/10907047/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:800: if (_onclose != null) {
There is a lot of inconsistency in the use of != / !== when comparing to null.
Lets use !== for all new code.

[Anders Johnsen, 2012-09-04 07:21:27]

PTAL

https://chromiumcodereview.appspot.com/10907047/diff/1/runtime/bin/websocket_...
File runtime/bin/websocket_impl.dart (right):

https://chromiumcodereview.appspot.com/10907047/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:220: } catch (e, s) {
On 2012/09/04 07:17:10, Søren Gjesse wrote:
> Are you using s?

I did (bug hunt) but removing.

https://chromiumcodereview.appspot.com/10907047/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:800: if (_onclose != null) {
On 2012/09/04 07:17:10, Søren Gjesse wrote:
> There is a lot of inconsistency in the use of != / !== when comparing to null.
> Lets use !== for all new code.

Done. (changed entire file for consistency).

[Søren Gjesse, 2012-09-04 08:43:51]

lgtm