Fix for issue 4921: ad the generic type info to a List when we create it.

Fix for issue 4921: ad the generic type info to a List when we create it.
Committed: https://code.google.com/p/dart/source/detail?r=12260

[kasperl, 2012-09-12 12:19:04]

LGTM.

https://chromiumcodereview.appspot.com/10905234/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10905234/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2641: String jsCode = '{
${Strings.join(typeVariables, ', ')} }';
Somehow the decoupling of the way you turn the type variables into an object
(split between callSetRuntimeTypeInfo and the callers of it) seems complicated.
Would it be terrible to pass in the list of TypeVariableTypes and convert them
to an object literal in a string inside callSetRuntimeTypeInfo?

https://chromiumcodereview.appspot.com/10905234/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10905234/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:2380: js.Prefix nullTest = new
js.Prefix('!', field);
Add a comment that explains why it is necessary to allow the non-exisiting type
field to pass as true? Maybe do null test before eq test? Seems a bit more
logical.

[ngeoffray, 2012-09-12 12:30:39]

Thanks Kasper.

https://chromiumcodereview.appspot.com/10905234/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10905234/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2641: String jsCode = '{
${Strings.join(typeVariables, ', ')} }';
On 2012/09/12 12:19:04, kasperl wrote:
> Somehow the decoupling of the way you turn the type variables into an object
> (split between callSetRuntimeTypeInfo and the callers of it) seems
complicated.
> Would it be terrible to pass in the list of TypeVariableTypes and convert them
> to an object literal in a string inside callSetRuntimeTypeInfo?

Done.

https://chromiumcodereview.appspot.com/10905234/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10905234/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:2380: js.Prefix nullTest = new
js.Prefix('!', field);
On 2012/09/12 12:19:04, kasperl wrote:
> Add a comment that explains why it is necessary to allow the non-exisiting
type
> field to pass as true? Maybe do null test before eq test? Seems a bit more
> logical.

Done.

[karlklose, 2012-09-12 12:43:55]

LGTM.