Whenever possible use length passed to the List constructor for bounds checks instead of loading it…

Whenever possible use length passed to the List constructor for bounds checks instead of loading it from the array object itself. 

R=srdjan@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=12254

[srdjan, 2012-09-12 10:29:58]

LGTM with comments

https://chromiumcodereview.appspot.com/10905233/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10905233/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:1691: call->set_is_constructor(true);
There is a Function::IsConstructor() and ::IsFactory() which you may use since
the StaticCallIInstr keeps the function.

https://chromiumcodereview.appspot.com/10905233/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10905233/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:2001: is_constructor_(false) {
No need for the field since it can be derived from function().

https://chromiumcodereview.appspot.com/10905233/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:3298: virtual bool HasSideEffect() const {
return false; }
AffectedBySideEffect is the new name.

[Vyacheslav Egorov (Google), 2012-09-12 10:45:25]

Renamed is_constructor to is_known_constructor to reflect its meaning: it tells
if the StaticCallInstr is a call to a known library constructor.

[Vyacheslav Egorov (Google), 2012-09-12 10:46:20]

Landed.