Add --step_name option to test.dart.

Add --step_name option to test.dart.

Committed: https://code.google.com/p/dart/source/detail?r=12296

[ahe, 2012-09-11 07:46:10]

This is needed to unbreak this page: 

http://chromegw.corp.google.com/i/client.dart/stats/dart2js-linux-release-1-4

Look at the errors in Chrome developer tool. The problem is that the server
creates a variable like this:

var stepTimesfailures20120910042222.774 = [ ... ]

Even if we escaped the '.', we would be generating a new step name each time
there is a failure. So eventually the page would get really long.

[ricow1, 2012-09-11 08:14:38]

I have one concern, but other then that LGTM and thanks for doing this

https://chromiumcodereview.appspot.com/10905208/diff/1/dart/tools/test.dart
File dart/tools/test.dart (right):

https://chromiumcodereview.appspot.com/10905208/diff/1/dart/tools/test.dart#n...
dart/tools/test.dart:83: if (progressIndicator == 'buildbot' && stepName !==
null) {
I am not particularly happy about having buildbot related stuff in the main
general purpose test script - even if it is only a print statement.

https://chromiumcodereview.appspot.com/10905208/diff/1/dart/utils/compiler/bu...
File dart/utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10905208/diff/1/dart/utils/compiler/bu...
dart/utils/compiler/buildbot.py:120: 
Why don't we print the @@@BUILD_STEP $step_name@@@ here instead of in the
test.dart script?

[Bill Hesse, 2012-09-11 10:26:53]

LGTM, if Rico's suggestion can't work.

I don't know if passing this step name through ProcessQueue, and through the
parent Progress indicator factory is really justified.  This is a global setting
read by test_options, and read by one class, the buildbot progress indicator. 
So why not make it a static field of BuildbotProgressIndicator and set it from
test_options?

https://chromiumcodereview.appspot.com/10905208/diff/1/dart/tools/test.dart
File dart/tools/test.dart (right):

https://chromiumcodereview.appspot.com/10905208/diff/1/dart/tools/test.dart#n...
dart/tools/test.dart:78: var stepName = firstConf['step_name'];
How about BuildbotProgressIndicator.stepName = firstConf['step_name'].  Or a
setter.  Then it doesn't need to be passed as a parameter through two unrelated
class constructors.

[ahe, 2012-09-11 13:10:00]

PTAL

[Bill Hesse, 2012-09-11 13:21:44]

Much nicer.  LGTM.

[ricow1, 2012-09-11 16:51:53]

LGTM, let me know when this lands and I will flush the history again

[ahe, 2012-09-13 04:20:24]

On 2012/09/11 16:51:53, ricow1 wrote:
> LGTM, let me know when this lands and I will flush the history again

This has landed.