Look for git.cmd on Windows.

Look for git.cmd on Windows.

BUG=4947
Committed: https://code.google.com/p/dart/source/detail?r=12222

[Bob Nystrom, 2012-09-11 16:18:55]

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/pub/git_source.dart
File utils/pub/git_source.dart (right):

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/pub/git_source.d...
utils/pub/git_source.dart:241: Future<PubProcessResult> _runGit(List<String>
args, [String workingDir]) =>
How about moving this into io.dart? There's already some git-related stuff in
there.

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:485: Future<String> get gitCommand {
I would unify this with _runGit and just have a single method that invokes git
in an appropriate way.

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:987: return runProcess('git', args, workingDir:
workingDir.path);
Unquote 'git'. :)

[nweiz, 2012-09-11 19:25:11]

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/pub/git_source.dart
File utils/pub/git_source.dart (right):

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/pub/git_source.d...
utils/pub/git_source.dart:241: Future<PubProcessResult> _runGit(List<String>
args, [String workingDir]) =>
On 2012/09/11 16:18:55, Bob Nystrom wrote:
> How about moving this into io.dart? There's already some git-related stuff in
> there.

Done.

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:485: Future<String> get gitCommand {
On 2012/09/11 16:18:55, Bob Nystrom wrote:
> I would unify this with _runGit and just have a single method that invokes git
> in an appropriate way.

Done.

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10905202/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:987: return runProcess('git', args, workingDir:
workingDir.path);
On 2012/09/11 16:18:55, Bob Nystrom wrote:
> Unquote 'git'. :)

Done.

[Bob Nystrom, 2012-09-11 19:53:55]

Naming nit. Otherwise LGTM.

https://chromiumcodereview.appspot.com/10905202/diff/7001/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10905202/diff/7001/utils/pub/io.dart#n...
utils/pub/io.dart:478: String __gitCommand;
"_gitCommandCache"