Issue 10905139: Fix status files for browser checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905139: Fix status files for browser checked mode. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix status files for browser checked mode. Committed: https://code.google.com/p/dart/source/detail?r=11998

Patch Set 3 : #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -2 lines)			Patch
M	pkg/pkg.status	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	samples/tests/samples/samples.status	View	1 2	1 chunk	+7 lines, -0 lines	2 comments	Download
M	tests/html/html.status	View	1 2	1 chunk	+86 lines, -2 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/json/json.status	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM, but: http://codereview.chromium.org/10905139/diff/1007/samples/tests/samples/samples.status File samples/tests/samples/samples.status (right): http://codereview.chromium.org/10905139/diff/1007/samples/tests/samples/samples.status#newcode90 samples/tests/samples/samples.status:90: lib/observable/observable_test: Fail I had to remove observable_test ...

8 years, 3 months ago (2012-09-07 05:47:51 UTC) #2

ngeoffray

8 years, 3 months ago (2012-09-07 06:19:38 UTC) #3

http://codereview.chromium.org/10905139/diff/1007/samples/tests/samples/sampl...
File samples/tests/samples/samples.status (right):

http://codereview.chromium.org/10905139/diff/1007/samples/tests/samples/sampl...
samples/tests/samples/samples.status:90: lib/observable/observable_test: Fail
On 2012/09/07 05:47:51, kasperl wrote:
> I had to remove observable_test and util_test again. Maybe you can double
check
> why they no longer fail on int checks?

I believe it's the test framework with browser tests that use ints not in the JS
range.

Expand Messages | Collapse Messages

Issue 10905139: Fix status files for browser checked mode. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages