Issue 10905125: Move dart:web to pkg:htmlescape.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905125: Move dart:web to pkg:htmlescape. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move dart:web to pkg:htmlescape. Committed: https://code.google.com/p/dart/source/detail?r=11943

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comments. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -98 lines)			Patch
M	lib/_internal/libraries.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	lib/web/web.dart	View		1 chunk	+0 lines, -22 lines	0 comments	Download
A +	pkg/htmlescape/htmlescape.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download
A	pkg/htmlescape/pubspec.yaml	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/intl/intl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/intl/pubspec.yaml	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/bin.gypi	View		7 chunks	+0 lines, -36 lines	0 comments	Download
M	runtime/bin/builtin.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/builtin.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/bin/builtin_nolib.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	runtime/bin/dartutils.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/dartutils.cc	View		3 chunks	+0 lines, -8 lines	0 comments	Download
D	runtime/bin/web_sources.gypi	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/create_sdk.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 3 months ago (2012-09-06 12:32:23 UTC) #2

LGTM with comment.

-Ivan

https://chromiumcodereview.appspot.com/10905125/diff/1/runtime/bin/builtin_no...
File runtime/bin/builtin_nolib.cc (right):

https://chromiumcodereview.appspot.com/10905125/diff/1/runtime/bin/builtin_no...
runtime/bin/builtin_nolib.cc:28: return
Dart_NewString(builtin_libraries_[id].source_);
return Dart_NewApiError("Unreachable code in Builtin::Source (%d).", id);

Expand Messages | Collapse Messages