Issue 10905102: Rename Builtin::LoadLibrary to Builtin::LoadAndCheckLibrary as the name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905102: Rename Builtin::LoadLibrary to Builtin::LoadAndCheckLibrary as the name (Closed)

Created:
8 years, 3 months ago by siva

Modified:
8 years, 3 months ago

Reviewers:
Anton Muhin, hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Rename Builtin::LoadLibrary to Builtin::LoadAndCheckLibrary as the name LoadLibrary seems to conflict with some windows predefined macros causing build failures on windows build of dartium. Committed: https://code.google.com/p/dart/source/detail?r=11894

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -24 lines)			Patch
M	runtime/bin/builtin.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/builtin.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/builtin_nolib.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/main.cc	View	3 chunks	+9 lines, -6 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages