Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 10905065: Revert r11772: Add check for non-smi to the IL and use it for class checks. (Closed)

Created:
8 years, 3 months ago by Florian Schneider
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert r11772: Add check for non-smi to the IL and use it for class checks. In its current state this causes some performance regressions because we can't eliminate non-smi checks properly in the optimizer. TBR=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=11774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -79 lines) Patch
M runtime/vm/code_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +0 lines, -30 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 3 months ago (2012-09-03 16:58:07 UTC) #1
Vyacheslav Egorov (Google)
8 years, 3 months ago (2012-09-03 16:58:25 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698