Issue 10905062: Fix issue 4361 by checking in the resolver if the getter/setter exists.

Issue 10905062: Fix issue 4361 by checking in the resolver if the getter/setter exists. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
karlklose, ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 4361 by checking in the resolver if the getter/setter exists. Committed: https://code.google.com/p/dart/source/detail?r=11792

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -24 lines)			Patch
M	lib/compiler/implementation/resolver.dart	View	1	3 chunks	+14 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A +	tests/language/getter_no_setter2_test.dart	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/language/setter_no_getter_call_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tests/language/setter_no_getter_test.dart	View	1	1 chunk	+3 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

Less crashes is great! But isn't Karl working on changing things like this to be ...

8 years, 3 months ago (2012-09-03 16:55:07 UTC) #2

kasperl

LGTM as long as you coordinate this with Karl (who is working on something similar). ...

8 years, 3 months ago (2012-09-04 05:50:07 UTC) #3

ngeoffray

8 years, 3 months ago (2012-09-04 08:32:14 UTC) #5

Thanks all

https://chromiumcodereview.appspot.com/10905062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10905062/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:1333: error(node.selector,
MessageKind.CANNOT_RESOLVE_GETTER);
On 2012/09/04 05:50:07, kasperl wrote:
> This should definitely be coordinated with Karl, but maybe just adding a TODO
> here would make him spot this point easily.

Done.

https://chromiumcodereview.appspot.com/10905062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/warnings.dart (right):

https://chromiumcodereview.appspot.com/10905062/diff/1/lib/compiler/implement...
lib/compiler/implementation/warnings.dart:236: 'Cannot resolve getter.');
On 2012/09/04 05:50:07, kasperl wrote:
> Error: cannot ...

Actually, we now get printed Error: Error :-( So we should remove all Error: and
Warning: from the MessageKind.

Expand Messages | Collapse Messages