Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10905049: Implementing window.createObjectURL* (Closed)

Created:
8 years, 3 months ago by blois
Modified:
8 years, 3 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implementing window.createObjectURL* BUG=4231 Committed: https://code.google.com/p/dart/source/detail?r=11979

Patch Set 1 #

Patch Set 2 : Integrating latest from tree. #

Patch Set 3 : Syncing to latest. #

Patch Set 4 : Fixing merge issue. #

Patch Set 5 : Incorporating API feedback. #

Patch Set 6 : Incorporating API feedback. #

Patch Set 7 : Further API cleanup. #

Total comments: 2

Patch Set 8 : Incorporating review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M lib/dom/templates/html/dart2js/impl_Window.darttemplate View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M lib/dom/templates/html/interface/interface_Window.darttemplate View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 2 chunks +17 lines, -0 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A tests/html/url_test.dart View 1 2 3 4 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
8 years, 3 months ago (2012-09-04 21:27:07 UTC) #1
blois
On 2012/09/04 21:27:07, blois wrote: Incorporated feedback on API, now have a single untyped createObjectURL() ...
8 years, 3 months ago (2012-09-05 21:12:40 UTC) #2
vsm
lgtm https://chromiumcodereview.appspot.com/10905049/diff/2008/lib/dom/templates/html/interface/interface_Window.darttemplate File lib/dom/templates/html/interface/interface_Window.darttemplate (right): https://chromiumcodereview.appspot.com/10905049/diff/2008/lib/dom/templates/html/interface/interface_Window.darttemplate#newcode38 lib/dom/templates/html/interface/interface_Window.darttemplate:38: String createObjectUrl(object); Can you add comments on the ...
8 years, 3 months ago (2012-09-05 21:17:23 UTC) #3
blois
8 years, 3 months ago (2012-09-05 21:36:50 UTC) #4 
https://chromiumcodereview.appspot.com/10905049/diff/2008/lib/dom/templates/h...
File lib/dom/templates/html/interface/interface_Window.darttemplate (right):

https://chromiumcodereview.appspot.com/10905049/diff/2008/lib/dom/templates/h...
lib/dom/templates/html/interface/interface_Window.darttemplate:38: String
createObjectUrl(object);
On 2012/09/05 21:17:23, vsm wrote:
> Can you add comments on the interface?  In particular, on the allowed types
for
> object?

Done.

Powered by Google App Engine
This is Rietveld 408576698