Issue 10905018: Add print closure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905018: Add print closure. (Closed)

Created:
8 years, 3 months ago by Anton Muhin

Modified:
8 years, 3 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add print closure. Also minor refactorings. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=11624

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
	M	lib/dom/src/Timer.dart	View	1	1 chunk	+15 lines, -16 lines	0 comments	Download
	M	lib/dom/src/native_DOMImplementation.dart	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://chromiumcodereview.appspot.com/10905018/diff/1/lib/dom/src/Timer.dart File lib/dom/src/Timer.dart (right): https://chromiumcodereview.appspot.com/10905018/diff/1/lib/dom/src/Timer.dart#newcode15 lib/dom/src/Timer.dart:15: var maker, canceller; separate statements, please. https://chromiumcodereview.appspot.com/10905018/diff/1/lib/dom/src/native_DOMImplementation.dart File ...

8 years, 3 months ago (2012-08-30 15:43:47 UTC) #2

Anton Muhin

8 years, 3 months ago (2012-08-30 16:12:28 UTC) #3

https://chromiumcodereview.appspot.com/10905018/diff/1/lib/dom/src/Timer.dart
File lib/dom/src/Timer.dart (right):

https://chromiumcodereview.appspot.com/10905018/diff/1/lib/dom/src/Timer.dart...
lib/dom/src/Timer.dart:15: var maker, canceller;
On 2012/08/30 15:43:47, podivilov wrote:
> separate statements, please.

Done.

https://chromiumcodereview.appspot.com/10905018/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/10905018/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMImplementation.dart:113: Utils_print(s);
Well spotted, absolutely, it should go into Utils now.

On 2012/08/30 15:43:47, podivilov wrote:
> While you are here, could you please make Utils_print private?

Expand Messages | Collapse Messages

Issue 10905018: Add print closure. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages