Hook up the --minify option in dart2js and use it to get rid of unnecessary whitespace inside funct…

Hook up the --minify option in dart2js and use it to get rid of unnecessary whitespace inside function bodies.


R=floitsch@google.com,ahe@google.com,antonm@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11517

[kasperl, 2012-08-29 10:23:59]

I think we need to chat about how we want to go about testing the --minify
option and also if it has the right name. Does it need a shorter variant (-m)
too?

[Anton Muhin, 2012-08-29 10:29:16]

LGTM w/ comment addressed.

As of now dart2dart does two runs on bbs: first w/o minification and then with
it.  But we currently running only a small share of tests.

https://chromiumcodereview.appspot.com/10901002/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10901002/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:15: minify =
compiler.enableMinification,
I'd rather add a getter or omit it altogether and fetch it in renamer.

[floitsch, 2012-08-29 10:30:38]

LGTM.

[ahe, 2012-08-29 10:48:05]

The changes as such, LGTM.

The option name and its documentation should be improved. I suggest we take
advantage of having Kathy on site and discuss it with her.

Cheers,
Peter

[kasperl, 2012-08-29 11:22:53]

Anton, I've tried to address your concerns. PTAL.

Adding Kathy as a reviewer (thanks Peter) to get a fresh set of eyes on the new
option (--minify) and the associated documentation. The only file you'll need to
look at lib/compiler/implementation/dart2js.dart.

[Kathy Walrath, 2012-08-29 12:27:51]

lgtm

I only looked at the strings in lib/compiler/implementation/dart2js.dart.

[Anton Muhin, 2012-08-29 13:20:48]

Thanks a lot, Kasper