Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 10900015: Create packages directories in test/ and bin/ as well as at the top level. (Closed)

Created:
8 years, 3 months ago by nweiz
Modified:
8 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create packages directories in test/ and bin/ as well as at the top level. This is necessary to run Dart files in these directories. Committed: https://code.google.com/p/dart/source/detail?r=11549

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -1 line) Patch
M utils/pub/entrypoint.dart View 2 chunks +61 lines, -1 line 2 comments Download
M utils/tests/pub/pub_install_test.dart View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
8 years, 3 months ago (2012-08-29 00:53:37 UTC) #1
Bob Nystrom
We should talk about what this means for example/ too. https://chromiumcodereview.appspot.com/10900015/diff/1/utils/pub/entrypoint.dart File utils/pub/entrypoint.dart (right): https://chromiumcodereview.appspot.com/10900015/diff/1/utils/pub/entrypoint.dart#newcode262 ...
8 years, 3 months ago (2012-08-29 16:56:48 UTC) #2
nweiz
https://chromiumcodereview.appspot.com/10900015/diff/1/utils/pub/entrypoint.dart File utils/pub/entrypoint.dart (right): https://chromiumcodereview.appspot.com/10900015/diff/1/utils/pub/entrypoint.dart#newcode262 utils/pub/entrypoint.dart:262: Future<List<String>> _listDirWithoutPackages(dir) { On 2012/08/29 16:56:48, Bob Nystrom wrote: ...
8 years, 3 months ago (2012-08-29 19:57:58 UTC) #3
Bob Nystrom
8 years, 3 months ago (2012-08-29 20:33:05 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698