Add compiler error when instantiating abstract class

Add compiler error when instantiating abstract class

Also, make abstract keyword on methods optional.
Committed: https://code.google.com/p/dart/source/detail?r=11558

[regis, 2012-08-29 20:58:27]

LGTM with comments

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:576: void MarkAbstract(bool flag) {
This name is misleading, since MarkAbstract(false) will not do anything. How
about set_is_abstract() and only call if flag is true?

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2490: bool must_have_body =
const bool

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2502: !method->has_static &&
indentation

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2510: // Signature is not followd by semicolon or body.
Issue an
followed

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2512: bool must_have_semicolon =
const bool

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2553: members->MarkAbstract(method->has_abstract);
if (method->has_abstract) members->set_is_abstract();

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:3051: members.MarkAbstract(is_abstract);
ditto

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:8600: if (type_class.is_abstract() &&
!constructor.IsFactory()) {
Why don't you check constructor_class instead of type_class?
if (constructor_class.is_abstract()) {
  ErrorMsg(...);
}

http://codereview.chromium.org/10899039/diff/5001/tests/language/get_set_synt...
File tests/language/get_set_syntax_test.dart (left):

http://codereview.chromium.org/10899039/diff/5001/tests/language/get_set_synt...
tests/language/get_set_syntax_test.dart:44: new C0();
You could keep them:
new C0();  /// 16: compile-time error
...

http://codereview.chromium.org/10899039/diff/5001/tests/language/get_set_synt...
File tests/language/get_set_syntax_test.dart (right):

http://codereview.chromium.org/10899039/diff/5001/tests/language/get_set_synt...
tests/language/get_set_syntax_test.dart:25: List get a;
You could add an
abstract List get a2;

[hausner, 2012-08-29 21:56:12]

Thank you.

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:576: void MarkAbstract(bool flag) {
On 2012/08/29 20:58:27, regis wrote:
> This name is misleading, since MarkAbstract(false) will not do anything. How
> about set_is_abstract() and only call if flag is true?

Done.

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2490: bool must_have_body =
On 2012/08/29 20:58:27, regis wrote:
> const bool

Done.

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2502: !method->has_static &&
On 2012/08/29 20:58:27, regis wrote:
> indentation

Done.

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2510: // Signature is not followd by semicolon or body.
Issue an
On 2012/08/29 20:58:27, regis wrote:
> followed

Done.

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2512: bool must_have_semicolon =
On 2012/08/29 20:58:27, regis wrote:
> const bool

Done.

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2553: members->MarkAbstract(method->has_abstract);
On 2012/08/29 20:58:27, regis wrote:
> if (method->has_abstract) members->set_is_abstract();

Done.

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:3051: members.MarkAbstract(is_abstract);
On 2012/08/29 20:58:27, regis wrote:
> ditto

Done.

http://codereview.chromium.org/10899039/diff/5001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:8600: if (type_class.is_abstract() &&
!constructor.IsFactory()) {
On 2012/08/29 20:58:27, regis wrote:
> Why don't you check constructor_class instead of type_class?
> if (constructor_class.is_abstract()) {
>   ErrorMsg(...);
> }

Ok. In a short while, when we get rid of interfaces, the two will be the same I
think.

http://codereview.chromium.org/10899039/diff/5001/tests/language/get_set_synt...
File tests/language/get_set_syntax_test.dart (left):

http://codereview.chromium.org/10899039/diff/5001/tests/language/get_set_synt...
tests/language/get_set_syntax_test.dart:44: new C0();
On 2012/08/29 20:58:27, regis wrote:
> You could keep them:
> new C0();  /// 16: compile-time error
> ...

Good idea. At least one of them.

http://codereview.chromium.org/10899039/diff/5001/tests/language/get_set_synt...
File tests/language/get_set_syntax_test.dart (right):

http://codereview.chromium.org/10899039/diff/5001/tests/language/get_set_synt...
tests/language/get_set_syntax_test.dart:25: List get a;
On 2012/08/29 20:58:27, regis wrote:
> You could add an
> abstract List get a2;

Done.