Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10898030: Put "super" in quotes. (Closed)

Created:
8 years, 3 months ago by floitsch
Modified:
8 years, 3 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Put "super" in quotes. Fixes issue 4759. Committed: https://code.google.com/p/dart/source/detail?r=11607

Patch Set 1 #

Patch Set 2 : Update test. #

Patch Set 3 : 80 chars. #

Patch Set 4 : Update authors file. #

Patch Set 5 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M dart/lib/compiler/implementation/js_backend/emitter.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/class_codegen_test.dart View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js/no_constructor_body_test.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
8 years, 3 months ago (2012-08-29 17:22:06 UTC) #1
kasperl
LGTM.
8 years, 3 months ago (2012-08-30 10:49:56 UTC) #2
floitsch
Updated AUTHORs file.
8 years, 3 months ago (2012-08-30 11:32:28 UTC) #3
kasperl
8 years, 3 months ago (2012-08-30 11:35:07 UTC) #4
Till LGTM. Special thanks to Chris for the original patch(es)!

Powered by Google App Engine
This is Rietveld 408576698