Issue 10898003: Remove List.copyFrom from VM and from tests. It was removed from the List interface in r941.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10898003: Remove List.copyFrom from VM and from tests. It was removed from the List interface in r941. (Closed)

Created:
8 years, 3 months ago by Bill Hesse

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove List.copyFrom from VM and from tests. It was removed from the List interface in r941. BUG=dart:1953 Committed: https://code.google.com/p/dart/source/detail?r=11437

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment, fix error. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -45 lines)			Patch
M	lib/dom/src/native_DOMImplementation.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_Element.darttemplate	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	lib/html/src/DocumentFragmentWrappingImplementation.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/lib/array.dart	View		2 chunks	+5 lines, -9 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/corelib/const_list_literal_test.dart	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	tests/corelib/growable_object_array2_vm_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/corelib/growable_object_array_vm_test.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/list_test.dart	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 3 months ago (2012-08-28 11:32:23 UTC) #2

LGTM! Thanks Bill

http://codereview.chromium.org/10898003/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

http://codereview.chromium.org/10898003/diff/1/tests/co19/co19-runtime.status...
tests/co19/co19-runtime.status:173: LibTest/core/List/sort_A01_t03: Fail, OK #
No method List.copyFrom.
Use same comment than in the other status file?

Expand Messages | Collapse Messages