Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 10894048: Revert change 11558 (Closed)

Created:
8 years, 3 months ago by hausner
Modified:
8 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert change 11558 I learnt that instantiating an abstract class is a runtime error, not a compile time error. TBR=regis Committed: https://code.google.com/p/dart/source/detail?r=11567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -168 lines) Patch
M runtime/vm/object.h View 2 chunks +1 line, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 10 chunks +22 lines, -63 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +6 lines, -38 lines 0 comments Download
A + tests/language/abstract_factory_constructor_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language/abstract_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/empty_body_member_negative_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language/get_set_syntax_test.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M tests/language/implicit_this_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D tests/language/interface_negative_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
A + tests/language/interface_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language/language.status View 2 chunks +1 line, -1 line 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
Sorry for the trouble.
8 years, 3 months ago (2012-08-29 22:49:38 UTC) #1
regis
8 years, 3 months ago (2012-08-29 22:50:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698