Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 10892034: Update V8 to 3.12. (Closed)

Created:
8 years, 3 months ago by ahe
Modified:
8 years, 3 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update V8 to 3.12. This includes moving some xcode settings to runtime-configurations.gypi as they were conflicting with v8 build. Testing: $ ./tools/build.py -mrelease --arch=x64,ia32 $ ./tools/test.py -mrelease --arch ia32,x64 $ file xcodebuild/ReleaseIA32/dart xcodebuild/ReleaseX64/dart xcodebuild/ReleaseIA32/d8 xcodebuild/ReleaseX64/d8 xcodebuild/ReleaseIA32/dart: Mach-O executable i386 xcodebuild/ReleaseX64/dart: Mach-O 64-bit executable x86_64 xcodebuild/ReleaseIA32/d8: Mach-O executable i386 xcodebuild/ReleaseX64/d8: Mach-O executable i386 Committed: https://code.google.com/p/dart/source/detail?r=11597

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments and more clean-up #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -41 lines) Patch
M dart/runtime/tools/gyp/runtime-configurations.gypi View 1 1 chunk +43 lines, -1 line 0 comments Download
M dart/tools/gyp/all.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tools/gyp/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tools/gyp/configurations_xcode.gypi View 1 3 chunks +10 lines, -37 lines 2 comments Download
M deps/all.deps/DEPS View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
8 years, 3 months ago (2012-08-29 14:25:36 UTC) #1
ricow1
LGTM https://chromiumcodereview.appspot.com/10892034/diff/1/dart/tools/gyp/configurations_xcode.gypi File dart/tools/gyp/configurations_xcode.gypi (right): https://chromiumcodereview.appspot.com/10892034/diff/1/dart/tools/gyp/configurations_xcode.gypi#newcode52 dart/tools/gyp/configurations_xcode.gypi:52: 'Dart_simarm_Base': { I know that there is not ...
8 years, 3 months ago (2012-08-29 16:00:17 UTC) #2
ahe
PTAL https://chromiumcodereview.appspot.com/10892034/diff/1/dart/tools/gyp/configurations_xcode.gypi File dart/tools/gyp/configurations_xcode.gypi (right): https://chromiumcodereview.appspot.com/10892034/diff/1/dart/tools/gyp/configurations_xcode.gypi#newcode52 dart/tools/gyp/configurations_xcode.gypi:52: 'Dart_simarm_Base': { On 2012/08/29 16:00:17, ricow1 wrote: > ...
8 years, 3 months ago (2012-08-30 09:02:07 UTC) #3
ricow1
LGTM https://chromiumcodereview.appspot.com/10892034/diff/4003/dart/tools/gyp/configurations_xcode.gypi File dart/tools/gyp/configurations_xcode.gypi (left): https://chromiumcodereview.appspot.com/10892034/diff/4003/dart/tools/gyp/configurations_xcode.gypi#oldcode26 dart/tools/gyp/configurations_xcode.gypi:26: 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror we should discuss with ...
8 years, 3 months ago (2012-08-30 09:12:22 UTC) #4
ahe
8 years, 3 months ago (2012-08-30 09:24:30 UTC) #5
Thank you, Rico!

https://chromiumcodereview.appspot.com/10892034/diff/4003/dart/tools/gyp/conf...
File dart/tools/gyp/configurations_xcode.gypi (left):

https://chromiumcodereview.appspot.com/10892034/diff/4003/dart/tools/gyp/conf...
dart/tools/gyp/configurations_xcode.gypi:26: 'GCC_TREAT_WARNINGS_AS_ERRORS':
'YES', # -Werror
On 2012/08/30 09:12:22, ricow1 wrote:
> we should discuss with Ivan which of the rest of the GCC flags we can safely
> move over.

I agree. Also, the same clean up should be done for configurations_make.gypi.

Powered by Google App Engine
This is Rietveld 408576698