Reworked previous CL (ExternalStringGetPeer speed up) to avoid the

Reworked previous CL (ExternalStringGetPeer speed up) to avoid the
need for an 'extern "C"' declaration in raw_object.h, which broke
the Windows builds.  Instead, a peer() method is added to the
RawExternalString*Object classes, and RawObject::ToAddr() is used
to fetch the address of these raw instances.  This avoids the need
for Dart_ExternalStringGetPeer needing friend access to those classes.
Committed: https://code.google.com/p/dart/source/detail?r=11540

[Tom Ball, 2012-08-29 19:18:49]

The windows builds are failing due to a redeclaration of
Dart_ExternalStringGetPeer function in the 'extern "C"' block I added.  I
reworked the previous change to avoid the need for friend access by adding a
public peer() method.

[siva, 2012-08-29 19:39:10]

http://codereview.chromium.org/10891036/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

http://codereview.chromium.org/10891036/diff/1/runtime/vm/raw_object.h#newcod...
runtime/vm/raw_object.h:1134: }
We generally try to restrict this file to just have data and avoid any functions
here.
RawObject is a special case as it is used by GC and Snapshot code.

[Ivan Posva, 2012-08-29 20:03:36]

LGTM -ip

[Tom Ball, 2012-08-29 20:03:50]

http://codereview.chromium.org/10891036/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

http://codereview.chromium.org/10891036/diff/1/runtime/vm/raw_object.h#newcod...
runtime/vm/raw_object.h:1134: }
Ivan helped me rework the original code to avoid needing these, so they're gone
now.

On 2012/08/29 19:39:11, asiva wrote:
> We generally try to restrict this file to just have data and avoid any
functions
> here.
> RawObject is a special case as it is used by GC and Snapshot code.