Issue 10891022: Update corelib/ and lib/ to use the new try-catch syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10891022: Update corelib/ and lib/ to use the new try-catch syntax. (Closed)

Created:
8 years, 3 months ago by kasperl

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update corelib/ and lib/ to use the new try-catch syntax. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11504

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -48 lines)			Patch
M	corelib/src/expect.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	corelib/src/implementation/future_implementation.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/apiimpl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/compile_time_constants.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/dart2js.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/lib/isolate_patch.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/lib/regexp_helper.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/scanner/scanner_task.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/tools/mini_parser.dart	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/tree/nodes.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/typechecker.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/scripts/idlparser_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/dom/templates/html/dart2js/impl_Window.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/templates/html/impl/impl_Node.darttemplate	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/html/src/AnimationEventWrappingImplementation.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/src/Measurement.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/src/XMLElementWrappingImplementation.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/json/json.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 3 months ago (2012-08-29 08:40:23 UTC) #2

LGTM, but some of these edits contain generated files (eg lib/html)

Expand Messages | Collapse Messages