Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Issue 10891021: Add gcl presubmit script to the dart src tree. (Closed)

Created:
8 years, 3 months ago by ricow1
Modified:
8 years, 3 months ago
Reviewers:
ahe, Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add gcl presubmit script to the dart src tree. Currently I just added a tree status check but we can extend this over time. Committed: https://code.google.com/p/dart/source/detail?r=11575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A PRESUBMIT.py View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
8 years, 3 months ago (2012-08-29 08:03:31 UTC) #1
Mads Ager (google)
LGTM And this will play nice with the existing PRESUBMIT.py in runtime?
8 years, 3 months ago (2012-08-29 08:12:56 UTC) #2
ricow1
On 2012/08/29 08:12:56, Mads Ager wrote: > LGTM > > And this will play nice ...
8 years, 3 months ago (2012-08-29 08:15:56 UTC) #3
Mads Ager (google)
8 years, 3 months ago (2012-08-29 08:18:06 UTC) #4
On 2012/08/29 08:15:56, ricow1 wrote:
> On 2012/08/29 08:12:56, Mads Ager wrote:
> > LGTM
> > 
> > And this will play nice with the existing PRESUBMIT.py in runtime?
> 
> Yes, quote from documentation:
> When you run gcl upload or gcl commit, gcl will look for all files named
> PRESUBMIT.py in folders enclosing the files in your change, up to the
repository
> root.
> 
> For each such file, it will load the file into the Python interpreter and then
> call either the CheckChangeOnUpload or CheckChangeOnCommit function depending
on
> whether you are calling [gcl upload] or [gcl commit].

Awesome. :)

Powered by Google App Engine
This is Rietveld 408576698