Issue 10890009: Rewrite language/list_test to use Expect.throws, and to allow a TypeError exception in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10890009: Rewrite language/list_test to use Expect.throws, and to allow a TypeError exception in checked mode. (Closed)

Created:
8 years, 3 months ago by Bill Hesse

Modified:
8 years, 3 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rewrite language/list_test to use Expect.throws, and to allow a TypeError exception in checked mode. BUG= TEST=language/list_test Committed: https://code.google.com/p/dart/source/detail?r=11447

Patch Set 1 #

Total comments: 3

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -59 lines)			Patch
	M	tests/language/list_test.dart	View		2 chunks	+15 lines, -59 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM http://codereview.chromium.org/10890009/diff/1/tests/language/list_test.dart File tests/language/list_test.dart (right): http://codereview.chromium.org/10890009/diff/1/tests/language/list_test.dart#newcode56 tests/language/list_test.dart:56: }, (e) => true); Do you need to ...

8 years, 3 months ago (2012-08-28 14:17:07 UTC) #3

Bill Hesse

8 years, 3 months ago (2012-08-28 14:31:58 UTC) #5

http://codereview.chromium.org/10890009/diff/1/tests/language/list_test.dart
File tests/language/list_test.dart (right):

http://codereview.chromium.org/10890009/diff/1/tests/language/list_test.dart#...
tests/language/list_test.dart:56: }, (e) => true);
On 2012/08/28 14:17:07, ngeoffray wrote:
> Do you need to add this closure?

No, I don't.  Thanks for pointing that out.

Expand Messages | Collapse Messages