Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 10890007: Remove more warnings. (Closed)

Created:
8 years, 3 months ago by kasperl
Modified:
8 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M lib/compiler/implementation/compile_time_constants.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/compiler/implementation/patch_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/scanner_task.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M lib/compiler/implementation/tree/nodes.dart View 2 chunks +1 line, -2 lines 0 comments Download
M lib/compiler/implementation/tree/prettyprint.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/warnings.dart View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 3 months ago (2012-08-28 10:56:46 UTC) #1
ahe
Not sure the changes related to handling the resource tag belong in this CL. Otherwise, ...
8 years, 3 months ago (2012-08-29 04:43:25 UTC) #2
kasperl
8 years, 3 months ago (2012-08-29 05:56:20 UTC) #3
Thanks for the review, Peter. I agree that it was a mistake to bundle the
#resource tag changes into this CL. Sorry about that.

Powered by Google App Engine
This is Rietveld 408576698