Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 10889017: Repair bitrot in the utils/apidoc/mdn/ code. It now runs all the way through, (Closed)

Created:
8 years, 3 months ago by eub
Modified:
8 years, 3 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Repair bitrot in the utils/apidoc/mdn/ code. It now runs all the way through, though it currently doesn't seem to be getting any docs for members. Committed: https://code.google.com/p/dart/source/detail?r=11539

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -32 lines) Patch
M utils/apidoc/mdn/README.txt View 2 chunks +21 lines, -1 line 0 comments Download
M utils/apidoc/mdn/crawl.js View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/apidoc/mdn/extract.dart View 7 chunks +9 lines, -11 lines 4 comments Download
M utils/apidoc/mdn/extract.sh View 1 chunk +14 lines, -3 lines 0 comments Download
M utils/apidoc/mdn/extractRunner.js View 2 chunks +5 lines, -1 line 0 comments Download
M utils/apidoc/mdn/full_run.sh View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/mdn/postProcess.dart View 2 chunks +14 lines, -4 lines 0 comments Download
M utils/apidoc/mdn/prettyPrint.dart View 5 chunks +11 lines, -6 lines 0 comments Download
M utils/apidoc/mdn/search.js View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/mdn/util.dart View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eub
Hi, Jacob. I'm going to time out for now on getting this fully revived (and ...
8 years, 3 months ago (2012-08-28 22:53:57 UTC) #1
Jacob
looks good overall https://chromiumcodereview.appspot.com/10889017/diff/1/utils/apidoc/mdn/extract.dart File utils/apidoc/mdn/extract.dart (right): https://chromiumcodereview.appspot.com/10889017/diff/1/utils/apidoc/mdn/extract.dart#newcode15 utils/apidoc/mdn/extract.dart:15: // return LevelDom.wrapClientRect(n.$dom_getBoundingClientRect()); remove this commented ...
8 years, 3 months ago (2012-08-28 23:34:54 UTC) #2
eub
Thanks, Jacob. https://chromiumcodereview.appspot.com/10889017/diff/1/utils/apidoc/mdn/extract.dart File utils/apidoc/mdn/extract.dart (right): https://chromiumcodereview.appspot.com/10889017/diff/1/utils/apidoc/mdn/extract.dart#newcode15 utils/apidoc/mdn/extract.dart:15: // return LevelDom.wrapClientRect(n.$dom_getBoundingClientRect()); On 2012/08/28 23:34:54, Jacob ...
8 years, 3 months ago (2012-08-29 19:29:39 UTC) #3
Jacob
8 years, 3 months ago (2012-08-29 21:44:54 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698