Issue 10889010: Fix for issue 4776

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10889010: Fix for issue 4776 (Closed)

Created:
8 years, 3 months ago by Brian Wilkerson

Modified:
8 years, 3 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 4776 Committed: https://code.google.com/p/dart/source/detail?r=11479

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -2 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartMethodDefinition.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1	3 chunks	+28 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

http://codereview.chromium.org/10889010/diff/1/compiler/java/com/google/dart/compiler/ast/DartMethodDefinition.java File compiler/java/com/google/dart/compiler/ast/DartMethodDefinition.java (right): http://codereview.chromium.org/10889010/diff/1/compiler/java/com/google/dart/compiler/ast/DartMethodDefinition.java#newcode36 compiler/java/com/google/dart/compiler/ast/DartMethodDefinition.java:36: DartExpression redirectedTypeName, Oops... Why not DartTypeNode? It is "typeName" ...

8 years, 3 months ago (2012-08-28 21:08:11 UTC) #2

Brian Wilkerson

> Why not DartTypeNode? Good catch, and done. PTAL.

8 years, 3 months ago (2012-08-28 21:36:50 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 10889010: Fix for issue 4776 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages