Change how runtime type information is being set in the backend.

Change how runtime type information is being set in the backend.
Committed: https://code.google.com/p/dart/source/detail?r=11436

[ngeoffray, 2012-08-28 08:44:17]

The motivation for this change was initially to get rid of these
setRuntimeTypeInfo calls after a 'new' instruction that prevents the new
instruction to be generate at use site.

Also if the constructor sets the runtime type info instead of the call site, we
save some code because we don't emit the setRuntimeTypeInfo at each call site.

On swarm, we save 3KB. The solution is to pass the type variables as parameters
of constructors and factories, and let the constructors set the runtime info.

Also, by doing this change, I realized that the current implementation did not
handle factories well, where the factory would use another type variable for
creating an object. See test tests/language/factory_type_parameter_test.dart.

[kasperl, 2012-08-28 09:14:15]

LGTM.

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/lib/js_helper.dart:966: return res == null ?
JS('var', '{}') : res;
I'd prefer () around the comparison. Would it be possible to re-use the object
returned in the case res is null? Seems wasteful to allocate a new object every
single time.

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2503: if
(argument.element.isTypeVariable()) {
Maybe factor this code out into a helper function. It seems a bit complicated to
have this big closure right here.

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2509: ||
work.element.isGenerativeConstructor()) {
Aren't they also available as locals in generative constructors?

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2514: HInstruction foreign =  new
HForeign(
Remove extra space after =.

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:82: void addTypeVariables(Element
element,
Shouldn't this be something like addTypeParameters?

[ngeoffray, 2012-08-28 10:39:45]

Thanks Kasper

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/lib/js_helper.dart:966: return res == null ?
JS('var', '{}') : res;
On 2012/08/28 09:14:15, kasperl wrote:
> I'd prefer () around the comparison. Would it be possible to re-use the object
> returned in the case res is null? Seems wasteful to allocate a new object
every
> single time.

I added a TODO to do that once we have lazy static initializations.

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2503: if
(argument.element.isTypeVariable()) {
On 2012/08/28 09:14:15, kasperl wrote:
> Maybe factor this code out into a helper function. It seems a bit complicated
to
> have this big closure right here.

Done.

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2509: ||
work.element.isGenerativeConstructor()) {
On 2012/08/28 09:14:15, kasperl wrote:
> Aren't they also available as locals in generative constructors?

Good point. Done.

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2514: HInstruction foreign =  new
HForeign(
On 2012/08/28 09:14:15, kasperl wrote:
> Remove extra space after =.

Done.

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10888003/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:82: void addTypeVariables(Element
element,
On 2012/08/28 09:14:15, kasperl wrote:
> Shouldn't this be something like addTypeParameters?

Done.