Issue 10887016: Reapply DOMFormData => FormData rename. (this time with a fix for Dartium)

Issue 10887016: Reapply DOMFormData => FormData rename. (this time with a fix for Dartium) (Closed)

Created:
8 years, 3 months ago by Emily Fortuna

Modified:
8 years, 3 months ago

Reviewers:
vsm, ahe

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reapply DOMFormData => FormData rename. (this time with a fix for Dartium) Committed: https://code.google.com/p/dart/source/detail?r=11570

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+285 lines, -53 lines)			Patch
M	lib/compiler/implementation/lib/native_helper.dart	View	1 2 3	4 chunks	+5 lines, -0 lines	0 comments	Download
M	lib/dom/dart2js/dom_dart2js.dart	View	1 2 3	3 chunks	+20 lines, -1 line	0 comments	Download
M	lib/dom/dom.dart	View	1 2	2 chunks	+10 lines, -1 line	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/htmlrenamer.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/src/dart2js_FactoryProviders.dart	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
A	lib/dom/templates/html/dart2js/factoryprovider_FormData.darttemplate	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View		6 chunks	+37 lines, -18 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		4 chunks	+31 lines, -14 lines	0 comments	Download
M	lib/html/doc/html.dartdoc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
D	lib/html/doc/interface/DOMFormData.dartdoc	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
A	lib/html/doc/interface/FormData.dartdoc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
A	tests/html/form_data_test.dart	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
A	tests/html/form_element_test.dart	View	1 2 3	1 chunk	+83 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/testing/perf_testing/run_perf_tests.py	View	1	6 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This reapplies the original change with the addition of we do a slightly different form ...

8 years, 3 months ago (2012-08-28 23:30:55 UTC) #1

vsm

lgtm https://chromiumcodereview.appspot.com/10887016/diff/1/tests/html/form_element_test.dart File tests/html/form_element_test.dart (right): https://chromiumcodereview.appspot.com/10887016/diff/1/tests/html/form_element_test.dart#newcode25 tests/html/form_element_test.dart:25: form.innerHTML = '<input type="email" value="notemail" blaber="test"' Can you ...

8 years, 3 months ago (2012-08-29 18:31:51 UTC) #2

Emily Fortuna

https://chromiumcodereview.appspot.com/10887016/diff/1/tests/html/form_element_test.dart File tests/html/form_element_test.dart (right): https://chromiumcodereview.appspot.com/10887016/diff/1/tests/html/form_element_test.dart#newcode25 tests/html/form_element_test.dart:25: form.innerHTML = '<input type="email" value="notemail" blaber="test"' On 2012/08/29 18:31:51, ...

8 years, 3 months ago (2012-08-29 23:00:26 UTC) #3

Emily Fortuna

+compiler-dev because of change to lib/compiler/implementation/lib/native_helper.dart

8 years, 3 months ago (2012-08-29 23:02:20 UTC) #5

ahe

8 years, 3 months ago (2012-08-30 16:45:11 UTC) #6

Changes to lib/compiler/implementation/lib/native_helper.dart LGTM

Expand Messages | Collapse Messages