Issue 10886017: Fixing up file API tests to run (or fail) appropriately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10886017: Fixing up file API tests to run (or fail) appropriately. (Closed)

Created:
8 years, 3 months ago by blois

Modified:
8 years, 3 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing up file API tests to run (or fail) appropriately. BUG=3022 Committed: https://code.google.com/p/dart/source/detail?r=11541

Patch Set 1 #

Patch Set 2 : Fixing up comment error in html.status. #

Total comments: 1

Patch Set 3 : Incorporating review feedback. #

Patch Set 4 : Fixing bad merge. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -36 lines)			Patch
	M	tests/html/fileapi_test.dart	View	1 2	1 chunk	+48 lines, -29 lines	0 comments	Download
	M	tests/html/html.status	View	1 2 3	6 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 3 months ago (2012-08-28 22:24:09 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10886017/diff/2001/tests/html/fileapi_...
File tests/html/fileapi_test.dart (right):

https://chromiumcodereview.appspot.com/10886017/diff/2001/tests/html/fileapi_...
tests/html/fileapi_test.dart:31: successCallback: (DirectoryEntry e) {
Hmm, one problem with this pattern is that if the wrong type or number of args
is passed, this will throw an exception outside of the fail that the framework
won't catch.

Expand Messages | Collapse Messages