Issue 10883071: - Change "static final" to "static const" in the runtime/ directory.

Issue 10883071: - Change "static final" to "static const" in the runtime/ directory. (Closed)

Created:
8 years, 3 months ago by Ivan Posva

Modified:
8 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Change "static final" to "static const" in the runtime/ directory. - Fixed parsing of top-level static const. Committed: https://code.google.com/p/dart/source/detail?r=11425

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+370 lines, -365 lines)			Patch
M	runtime/bin/base64.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/common.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/directory_impl.dart	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	runtime/bin/file.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View		3 chunks	+29 lines, -29 lines	0 comments	Download
M	runtime/bin/http.dart	View		6 chunks	+94 lines, -94 lines	0 comments	Download
M	runtime/bin/http_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/http_parser.dart	View		2 chunks	+53 lines, -53 lines	0 comments	Download
M	runtime/bin/input_stream.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/process.dart	View		1 chunk	+28 lines, -28 lines	0 comments	Download
M	runtime/bin/socket_impl.dart	View		2 chunks	+14 lines, -14 lines	0 comments	Download
M	runtime/bin/stdio.dart	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/timer_impl.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/websocket.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/websocket_impl.dart	View	1	2 chunks	+27 lines, -27 lines	0 comments	Download
M	runtime/lib/byte_array.dart	View		30 chunks	+30 lines, -30 lines	0 comments	Download
M	runtime/lib/date_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/math_patch.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/lib/regexp_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2	16 chunks	+28 lines, -28 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2	3 chunks	+9 lines, -4 lines	0 comments	Download
M	runtime/vm/parser_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/snapshot_test.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/snapshot_test.dart	View	1	5 chunks	+18 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://chromiumcodereview.appspot.com/10883071/diff/4001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://chromiumcodereview.appspot.com/10883071/diff/4001/runtime/vm/dart_api_impl_test.cc#newcode2678 runtime/vm/dart_api_impl_test.cc:2678: name = Dart_NewString("_final_static_fld"); In our own code, we ...

8 years, 3 months ago (2012-08-27 22:12:04 UTC) #2

Ivan Posva

8 years, 3 months ago (2012-08-27 23:49:49 UTC) #3

https://chromiumcodereview.appspot.com/10883071/diff/4001/runtime/vm/dart_api...
File runtime/vm/dart_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/10883071/diff/4001/runtime/vm/dart_api...
runtime/vm/dart_api_impl_test.cc:2678: name =
Dart_NewString("_final_static_fld");
On 2012/08/27 22:12:04, hausner wrote:
> In our own code, we should fix outdated function names and variables.

Done.

https://chromiumcodereview.appspot.com/10883071/diff/4001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10883071/diff/4001/runtime/vm/parser.c...
runtime/vm/parser.cc:2593: // TODO(hausner): For now, all static const fields
are constant. Remove
On 2012/08/27 22:12:04, hausner wrote:
> Please revert change in this comment.

Mechanical replacement only works so far. Thanks for finding this.

Expand Messages | Collapse Messages