Issue 10883070: Implementing polyfills for insertAdjacent* to get them working on FF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10883070: Implementing polyfills for insertAdjacent* to get them working on FF. (Closed)

Created:
8 years, 3 months ago by blois

Modified:
8 years, 3 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implementing polyfills for insertAdjacent* to get them working on FF. Refactoring IE test to pass on IE9. This is essentially the same CL as before, but had to roll back because it broke on IE9. Specifically, insertAdjacentHTML is not supported on IE9 on table elements. It is fully supported on IE10. BUG=3600, 3685 Committed: https://code.google.com/p/dart/source/detail?r=11480

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+420 lines, -17 lines)			Patch
M	lib/dom/scripts/systemhtml.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_Element.darttemplate	View	3 chunks	+70 lines, -3 lines	0 comments	Download
M	lib/dom/templates/html/interface/interface_Element.darttemplate	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View	5 chunks	+86 lines, -9 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	5 chunks	+31 lines, -3 lines	0 comments	Download
M	lib/html/doc/interface/Element.dartdoc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	tests/html/element_add_test.dart	View	1 chunk	+201 lines, -0 lines	0 comments	Download
M	tests/html/element_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 3 months ago (2012-08-27 23:53:53 UTC) #2

lgtm

next time can you upload your old cl first and changes in a separate patch? 
it's easier to see the diff that way.  :-)

Expand Messages | Collapse Messages