Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 10883054: Split class and smi check from array operations. (Closed)

Created:
8 years, 3 months ago by Florian Schneider
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Split class and smi check from array operations. Array loads and stores have explicit receiver class check and index smi check instead of emitting the checks as part of the original instruction. This allows redundant checks before array operations to be eliminated. Committed: https://code.google.com/p/dart/source/detail?r=11385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -50 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 4 chunks +18 lines, -12 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 6 chunks +9 lines, -22 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 3 months ago (2012-08-27 13:34:34 UTC) #1
Vyacheslav Egorov (Google)
8 years, 3 months ago (2012-08-27 13:59:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698