Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 10882061: Clean up some warnings. (Closed)

Created:
8 years, 3 months ago by messick
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up some warnings. Committed: https://code.google.com/p/dart/source/detail?r=11396

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -43 lines) Patch
M compiler/java/com/google/dart/compiler/InternalCompilerException.java View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/PackageLibraryManager.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/common/SourceInfo.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartPrefixParser.java View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CyclicDeclarationException.java View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/buffer/BufferChangedEvent.java View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartModelException.java View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/ElementChangedEvent.java View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/search/SearchException.java View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/DartDebugCorePlugin.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/plugin.xml View 1 2 4 chunks +0 lines, -18 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/TypeProposalInfo.java View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SpecificContentAssistExecutor.java View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/folding/DefaultDartFoldingStructureProvider.java View 1 2 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
messick
I touched a lot of files. I'll be glad to remove the change if you ...
8 years, 3 months ago (2012-08-27 16:21:25 UTC) #1
Brian Wilkerson
LGTM
8 years, 3 months ago (2012-08-27 16:24:48 UTC) #2
danrubel
lgtm
8 years, 3 months ago (2012-08-27 16:35:43 UTC) #3
pquitslund
LGTM!
8 years, 3 months ago (2012-08-27 16:37:04 UTC) #4
devoncarew
8 years, 3 months ago (2012-08-27 16:42:41 UTC) #5
lgtm

Looks good; note that I landed a change to clean up imports in Resolver.java, so
you will want to do an update before your commit.

Powered by Google App Engine
This is Rietveld 408576698