Issue 10882056: Unify AssertionError.

Issue 10882056: Unify AssertionError. (Closed)

Created:
8 years, 3 months ago by Anders Johnsen

Modified:
8 years, 3 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Unify AssertionError. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11448

Patch Set 2 : Fix a few errors. #

Patch Set 4 : Move AssertionError to errors.dart. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	corelib/src/corelib_sources.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A +	corelib/src/errors.dart	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/lib/core.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/compiler/implementation/lib/mock.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/lib/error.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/error.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

I'm not sure this is ideal, so feel free to express any ideas you may ...

8 years, 3 months ago (2012-08-27 12:18:44 UTC) #1

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/10882056/diff/1/corelib/src/exceptions.dart File corelib/src/exceptions.dart (right): https://chromiumcodereview.appspot.com/10882056/diff/1/corelib/src/exceptions.dart#newcode198 corelib/src/exceptions.dart:198: class AssertionError { If we put it in ...

8 years, 3 months ago (2012-08-28 13:01:37 UTC) #3

Anders Johnsen

PTAL, it was not extensive enough to pass all tests.

8 years, 3 months ago (2012-08-28 14:18:26 UTC) #4

Mads Ager (google)

Same comment about naming still applies. Other than that it still looks good.

8 years, 3 months ago (2012-08-28 14:29:07 UTC) #5

Anders Johnsen

8 years, 3 months ago (2012-08-28 14:39:18 UTC) #6

Thank you, landing.

https://chromiumcodereview.appspot.com/10882056/diff/1/corelib/src/exceptions...
File corelib/src/exceptions.dart (right):

https://chromiumcodereview.appspot.com/10882056/diff/1/corelib/src/exceptions...
corelib/src/exceptions.dart:198: class AssertionError {
On 2012/08/28 13:01:37, Mads Ager wrote:
> If we put it in here we should probably call it AssertionException and make it
> implement Exception?

Sorry, didn't see that comment earlier on. I've created an errors.dart file in
corelib/src/, since these are indeed errors (defined in the spec as such).

Expand Messages | Collapse Messages