Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10880079: Emit deoptimization information at static calls (preparation for full deoptimization). … (Closed)

Created:
8 years, 3 months ago by srdjan
Modified:
8 years, 3 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Emit deoptimization information at stati calls (preparation for full deoptimization). Currently we use Deoptimization stubs to maintain the deoptimization info, do not emit stubs though for static calls. Any instruction that calls out of Dart code and into other Dart code or C++ may deoptimize. Committed: https://code.google.com/p/dart/source/detail?r=11467

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -48 lines) Patch
M runtime/vm/code_generator.h View 1 2 3 4 1 chunk +37 lines, -36 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 3 4 10 chunks +13 lines, -10 lines 0 comments Download
M runtime/vm/stack_frame.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
8 years, 3 months ago (2012-08-28 00:51:42 UTC) #1
srdjan
Note that this is only a part of the necessary changes to be able to ...
8 years, 3 months ago (2012-08-28 06:51:51 UTC) #2
srdjan
8 years, 3 months ago (2012-08-28 15:39:38 UTC) #3
Florian Schneider
Lgtm as a first step. I have a question about the deoptimization environment associated with ...
8 years, 3 months ago (2012-08-28 16:00:57 UTC) #4
srdjan
8 years, 3 months ago (2012-08-28 17:08:25 UTC) #5
Thanks for the review. In a next CL I will prepare the environment to exclude
the arguments.

https://chromiumcodereview.appspot.com/10880079/diff/8003/runtime/vm/flow_gra...
File runtime/vm/flow_graph_compiler.cc (right):

https://chromiumcodereview.appspot.com/10880079/diff/8003/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler.cc:242: AddDeoptStub(deopt_id, -1, kDeoptAtCall);
On 2012/08/28 16:00:57, Florian Schneider wrote:
> Maybe kNoTryIndex instead of -1.
> 
> Can you also eliminate passing the try_index in other call sites of
> AddDeoptStub?

Using kNoTryIndex, will eliminate try_index from AddDeoptStub in a next CL.

Powered by Google App Engine
This is Rietveld 408576698