Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10880068: - Change "static final" to "static const" in the lib/ directory. (Closed)

Created:
8 years, 3 months ago by Ivan Posva
Modified:
8 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

- Change "static final" to "static const" in the lib/ directory. Committed: https://code.google.com/p/dart/source/detail?r=11401

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6730 lines, -6730 lines) Patch
M lib/_internal/libraries.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/compiler.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M lib/compiler/implementation/colors.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/compile_time_constants.dart View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M lib/compiler/implementation/compiler.dart View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M lib/compiler/implementation/dart2js.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 2 3 chunks +35 lines, -35 lines 0 comments Download
M lib/compiler/implementation/js/precedence.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M lib/compiler/implementation/lib/coreimpl_patch.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/io.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/lib/isolate_patch.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/library_map.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/namer.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/keyword.dart View 1 2 1 chunk +48 lines, -48 lines 0 comments Download
M lib/compiler/implementation/scanner/listener.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/scanner_task.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M lib/compiler/implementation/scanner/token.dart View 1 2 3 chunks +147 lines, -147 lines 0 comments Download
M lib/compiler/implementation/source_map_builder.dart View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/js_names.dart View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 1 2 8 chunks +58 lines, -58 lines 0 comments Download
M lib/compiler/implementation/ssa/tracer.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/types.dart View 1 2 1 chunk +17 lines, -17 lines 0 comments Download
M lib/compiler/implementation/tree/nodes.dart View 1 2 2 chunks +24 lines, -24 lines 0 comments Download
M lib/compiler/implementation/tree/prettyprint.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/typechecker.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/universe.dart View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M lib/compiler/implementation/util/characters.dart View 1 2 1 chunk +110 lines, -110 lines 0 comments Download
M lib/compiler/implementation/warnings.dart View 1 2 1 chunk +96 lines, -96 lines 0 comments Download
M lib/crypto/hash_utils.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M lib/crypto/md5.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M lib/crypto/sha256.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/dart2js/dom_dart2js.dart View 1 2 178 chunks +1833 lines, -1833 lines 0 comments Download
M lib/dom/dom.dart View 1 2 93 chunks +997 lines, -997 lines 0 comments Download
M lib/dom/scripts/dartgenerator_test.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/scripts/idlparser.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M lib/dom/scripts/systemdart2js.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/scripts/systemhtml.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/scripts/systeminterface.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/src/KeyLocation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M lib/dom/src/KeyName.dart View 1 2 1 chunk +149 lines, -149 lines 0 comments Download
M lib/dom/src/ReadyState.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 185 chunks +1839 lines, -1839 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 98 chunks +1003 lines, -1003 lines 0 comments Download
M lib/html/src/Isolates.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/KeyboardEvent.dart View 1 2 3 chunks +159 lines, -159 lines 0 comments Download
M lib/html/src/Measurement.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/MutationEvent.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/OverflowEvent.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M lib/json/json.dart View 1 2 1 chunk +46 lines, -46 lines 0 comments Download
M lib/math/base.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M lib/uri/uri.dart View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M lib/utf/utf8.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M lib/utf/utf_core.dart View 1 2 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
8 years, 3 months ago (2012-08-27 15:28:26 UTC) #1
hausner
8 years, 3 months ago (2012-08-27 15:57:45 UTC) #2 
Phew. LGTM.

https://chromiumcodereview.appspot.com/10880068/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/10880068/diff/2001/lib/compiler/implem...
lib/compiler/implementation/compile_time_constants.dart:605:
List<VariableElement> getStaticFinalFieldsForEmission() {
Put a TODO to rename the function?

Powered by Google App Engine
This is Rietveld 408576698