Issue 10880066: Add --additional-compiler-flags option to tweak compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10880066: Add --additional-compiler-flags option to tweak compilation. (Closed)

Created:
8 years, 3 months ago by Anton Muhin

Modified:
8 years, 3 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, Roman

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add --additional-compiler-flags option to tweak compilation. For now it is only supported by dart2dart pipeline, but can be easily extended to other pipelines which require compilation step. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=11374

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tools/testing/dart/test_options.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://chromiumcodereview.appspot.com/10880066/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10880066/diff/1/tools/testing/dart/test_suite.dart#newcode452 tools/testing/dart/test_suite.dart:452: .split(const RegExp(' ')); can't we just split on ...

8 years, 3 months ago (2012-08-27 09:43:14 UTC) #2

Anton Muhin

8 years, 3 months ago (2012-08-27 09:45:37 UTC) #3

Thanks a lot for review, submitting

https://chromiumcodereview.appspot.com/10880066/diff/1/tools/testing/dart/tes...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10880066/diff/1/tools/testing/dart/tes...
tools/testing/dart/test_suite.dart:452: .split(const RegExp(' '));
On 2012/08/27 09:43:14, ricow1 wrote:
> can't we just split on ' ', instead of using a RegExp here?

Done.

Expand Messages | Collapse Messages