Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 10880055: Fix some compilation errors and warnings in Pub. (Closed)

Created:
8 years, 4 months ago by nweiz
Modified:
8 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix some compilation errors and warnings in Pub. Committed: https://code.google.com/p/dart/source/detail?r=11355

Patch Set 1 #

Patch Set 2 : More compilation fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M utils/pub/package.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/pubspec.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/root_source.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M utils/pub/version_solver.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
8 years, 4 months ago (2012-08-24 22:23:20 UTC) #1
Bob Nystrom
8 years, 4 months ago (2012-08-24 22:43:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698