Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 10880040: Support abstract getters without parameters. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org, hausner
Visibility:
Public.

Description

Support abstract getters without parameters. Committed: https://code.google.com/p/dart/source/detail?r=11293

Patch Set 1 #

Patch Set 2 : Found a foreign test with illegal formal parameters #

Patch Set 3 : Update language.status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -27 lines) Patch
M dart/lib/compiler/implementation/compile_time_constants.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/lib/compiler/implementation/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/elements/elements.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/lib/compiler/implementation/js/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/keyword.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/parser.dart View 1 chunk +11 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/scanner/scanner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/lib/compiler/implementation/ssa/nodes.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M dart/lib/compiler/implementation/tree/dartstring.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/lib/compiler/implementation/tree/nodes.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_property_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A dart/tests/language/abstract_getter_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
This change is not as big as it looks, but I could also remove all ...
8 years, 4 months ago (2012-08-24 05:47:51 UTC) #1
ngeoffray
LGTM!
8 years, 4 months ago (2012-08-24 07:07:52 UTC) #2
Johnni Winther
8 years, 4 months ago (2012-08-24 08:36:05 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698