Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 10880026: Record literal list type arguments and report errors when there are too many. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
Reviewers:
Anton Muhin, ngeoffray
CC:
reviews_dartlang.org, messick, karlklose
Visibility:
Public.

Description

Record literal list type arguments and report errors when there are too many. Committed: https://code.google.com/p/dart/source/detail?r=11286

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Updated dart2dart status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -17 lines) Patch
M dart/lib/compiler/implementation/resolver.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/listener.dart View 1 chunk +1 line, -3 lines 0 comments Download
M dart/lib/compiler/implementation/tree/nodes.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M dart/lib/compiler/implementation/tree/unparser.dart View 1 chunk +1 line, -5 lines 0 comments Download
M dart/tests/language/language.status View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
A dart/tests/language/list_literal_syntax_test.dart View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
8 years, 4 months ago (2012-08-23 17:32:40 UTC) #1
ngeoffray
LGTM!
8 years, 4 months ago (2012-08-23 17:39:23 UTC) #2
Anton Muhin
LGTM and thanks a lot, Peter.
8 years, 4 months ago (2012-08-23 18:44:15 UTC) #3
ahe
8 years, 4 months ago (2012-08-23 18:50:00 UTC) #4
Note to self: update dart2dart status before submitting.

Powered by Google App Engine
This is Rietveld 408576698