Use patching for regexp implementation.

Use patching for regexp implementation.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11218

[Anders Johnsen, 2012-08-23 09:08:38]

No change to library_map in dart2js?

[Mads Ager (google), 2012-08-23 09:11:06]

On 2012/08/23 09:08:38, ajohnsen wrote:
> No change to library_map in dart2js?

No, because this is in corelib impl and therefore coreimpl_patch is already in
the library_map.

[Anders Johnsen, 2012-08-23 09:11:36]

LGTM,

Ofc, my bad! Very nice :)

[Mads Ager (google), 2012-08-23 09:16:28]

Updated with real VM fix from Ivan. Committing.

[Lasse Reichstein Nielsen, 2012-08-23 09:24:06]

http://codereview.chromium.org/10880020/diff/2001/corelib/src/implementation/...
File corelib/src/implementation/regexp.dart (right):

http://codereview.chromium.org/10880020/diff/2001/corelib/src/implementation/...
corelib/src/implementation/regexp.dart:12: external String get pattern();
Can you remove the parentheses on the getters?

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/lib/coreimpl_patch.dart (right):

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:76: // TODO(ager): Split out
into regexp_patch.dart and allow #source in
Patch files should be named .dartp, not .dart.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:126: class
_MatchImplementation implements Match {
Name it _RegExpMatch or even _JsRegExpMatch.
There can be many Match implementations, and this one is just for RegExp
results, right?

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:134: final String pattern;
Fields above constructor.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:140: int start() => _start;
Seems superflous, just call the final field "start".

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:155: class
_AllMatchesIterable implements Iterable<Match> {
Put RegExp in the name somewhere.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:178: // _next is set by
#hasNext
I prefer [hasNext] to #hasNext. More consistent, even if the "#" notation does
make sense if you know HTML/CSS.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:191: _next =
_re.firstMatch(_str);
Slightly tricky that firstMatch really acts as nextMatch due to a hidden "g"
flag. Could you add a comment about that here.
I know this is one big hack anyway, but I bet this code will be around for a
while.

[Mads Ager (google), 2012-08-23 09:38:23]

http://codereview.chromium.org/10880020/diff/2001/corelib/src/implementation/...
File corelib/src/implementation/regexp.dart (right):

http://codereview.chromium.org/10880020/diff/2001/corelib/src/implementation/...
corelib/src/implementation/regexp.dart:12: external String get pattern();
On 2012/08/23 09:24:06, Lasse Reichstein Nielsen wrote:
> Can you remove the parentheses on the getters?

Just tried and the answer is no apparently. Build fails.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/lib/coreimpl_patch.dart (right):

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:76: // TODO(ager): Split out
into regexp_patch.dart and allow #source in
On 2012/08/23 09:24:06, Lasse Reichstein Nielsen wrote:
> Patch files should be named .dartp, not .dart.

No. They are Dart files. I removed the .dartp extension on purpose on
everythign.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:126: class
_MatchImplementation implements Match {
On 2012/08/23 09:24:06, Lasse Reichstein Nielsen wrote:
> Name it _RegExpMatch or even _JsRegExpMatch.
> There can be many Match implementations, and this one is just for RegExp
> results, right?

I don't want to rock the boat with that right now. Only doing unification right
now and I'm keeping the name that was there before.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:134: final String pattern;
On 2012/08/23 09:24:06, Lasse Reichstein Nielsen wrote:
> Fields above constructor.

Copied from other file. I can move them in a separate patch.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:140: int start() => _start;
On 2012/08/23 09:24:06, Lasse Reichstein Nielsen wrote:
> Seems superflous, just call the final field "start".

Yes, but this is not a getter and I don't want to rock the boat. This is just
copied. Cleanup in separate patches. :)

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:155: class
_AllMatchesIterable implements Iterable<Match> {
On 2012/08/23 09:24:06, Lasse Reichstein Nielsen wrote:
> Put RegExp in the name somewhere.

Copied.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:178: // _next is set by
#hasNext
On 2012/08/23 09:24:06, Lasse Reichstein Nielsen wrote:
> I prefer [hasNext] to #hasNext. More consistent, even if the "#" notation does
> make sense if you know HTML/CSS.

Copied. I'll update.

http://codereview.chromium.org/10880020/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/lib/coreimpl_patch.dart:191: _next =
_re.firstMatch(_str);
On 2012/08/23 09:24:06, Lasse Reichstein Nielsen wrote:
> Slightly tricky that firstMatch really acts as nextMatch due to a hidden "g"
> flag. Could you add a comment about that here.
> I know this is one big hack anyway, but I bet this code will be around for a
> while.

Copied. I'll add a comment in a separate patch.