Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 10879080: Implementing polyfills for insertAdjacent* to get them working on FF. (Closed)

Created:
8 years, 4 months ago by blois
Modified:
8 years, 3 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implementing polyfills for insertAdjacent* to get them working on FF. Implementing addHTML and addText. BUG=3600, 3685 Committed: https://code.google.com/p/dart/source/detail?r=11399

Patch Set 1 #

Patch Set 2 : Implementing addText, addHTML and polyfills for insertAdjacent* #

Patch Set 3 : Sync to latest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -17 lines) Patch
M lib/dom/scripts/systemhtml.py View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/dom/templates/html/impl/impl_Element.darttemplate View 3 chunks +70 lines, -3 lines 0 comments Download
M lib/dom/templates/html/interface/interface_Element.darttemplate View 1 chunk +11 lines, -0 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 5 chunks +86 lines, -9 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 5 chunks +31 lines, -3 lines 0 comments Download
M lib/html/doc/interface/Element.dartdoc View 1 chunk +8 lines, -0 lines 0 comments Download
A tests/html/element_add_test.dart View 1 chunk +204 lines, -0 lines 0 comments Download
M tests/html/element_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
Hey Vijay- This is the same CL that you've approved before, I just made a ...
8 years, 3 months ago (2012-08-27 16:56:09 UTC) #1
vsm
8 years, 3 months ago (2012-08-27 16:57:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698