Issue 10879071: Skip the new pub tests on platforms where they don't belong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10879071: Skip the new pub tests on platforms where they don't belong. (Closed)

Created:
8 years, 3 months ago by nweiz

Modified:
8 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Skip the new pub tests on platforms where they don't belong. Committed: https://code.google.com/p/dart/source/detail?r=11338

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	utils/tests/pub/pub.status	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 3 months ago (2012-08-24 20:06:26 UTC) #2

I don't know where pub should and shouldn't run, but I think it should be able
to be analyzed by the analyzer (dartc). I do know that the reason the dartc
tests failed is because there is a real syntax error in utils/pub/source.dart
(missing semicolon at the end of line 111). Once that code has been fixed then
you should consider re-enabling the analyzer tests.

Expand Messages | Collapse Messages