Issue 10879041: Validate well-formedness of the use lists in debug mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10879041: Validate well-formedness of the use lists in debug mode. (Closed)

Created:
8 years, 4 months ago by zerny-google

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider, Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Validate well-formedness of the use lists in debug mode. R=fschneider@google.com,kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=11379

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -53 lines)			Patch
M	runtime/vm/compiler.cc	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1 2	5 chunks	+126 lines, -46 lines	2 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zerny-google

I copied over the old validation code to assert that the use lists are indeed ...

8 years, 4 months ago (2012-08-23 16:47:13 UTC) #1

zerny-google

Moved the validation code to a member of FlowGraph and removed the DefUseCleanup stuff.

8 years, 3 months ago (2012-08-27 08:25:13 UTC) #2

Kevin Millikin (Google)

8 years, 3 months ago (2012-08-27 12:11:11 UTC) #4

Still lgtm.

http://codereview.chromium.org/10879041/diff/2003/runtime/vm/flow_graph.cc
File runtime/vm/flow_graph.cc (right):

http://codereview.chromium.org/10879041/diff/2003/runtime/vm/flow_graph.cc#ne...
runtime/vm/flow_graph.cc:106: // Reset use lists of parameters in the start
environment.
It's not just parameters, but all definitions, right?

http://codereview.chromium.org/10879041/diff/2003/runtime/vm/flow_graph.cc#ne...
runtime/vm/flow_graph.cc:166: // Validate parameters in the start environment.
All definitions.

Expand Messages | Collapse Messages