Issue 10879005: Split BinaryOp into BinarySmiOp and BinaryMintOp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10879005: Split BinaryOp into BinarySmiOp and BinaryMintOp. (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Split BinaryOp into BinarySmiOp and BinaryMintOp. This refactoring is a preparation for inserting explicit class checks for arithmetic operations. Committed: https://code.google.com/p/dart/source/detail?r=11132

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+224 lines, -220 lines)			Patch
M	runtime/vm/code_generator.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	5 chunks	+24 lines, -15 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	5 chunks	+49 lines, -24 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+18 lines, -16 lines	1 comment	Download
M	runtime/vm/intermediate_language_ia32.cc	View	12 chunks	+61 lines, -81 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	12 chunks	+59 lines, -79 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 4 months ago (2012-08-22 11:15:23 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10879005/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10879005/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:994: return (op_kind() == Token::kSHL)
I would prefer if-statement when ?: does not fit on one line.

Expand Messages | Collapse Messages