Unify list.

Unify list.

I've added a TODO that we'll have to address asap. This patch will
currently limit the checks being performed with List.from(other).

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11384

[Anders Johnsen, 2012-08-27 13:56:45]

https://chromiumcodereview.appspot.com/10878077/diff/1/corelib/src/implementa...
File corelib/src/implementation/list.dart (right):

https://chromiumcodereview.appspot.com/10878077/diff/1/corelib/src/implementa...
corelib/src/implementation/list.dart:24: // TODO(ajohnsen): Make external once
the vm can handle it, so we don't
Should I file a bug and add issue number here?

https://chromiumcodereview.appspot.com/10878077/diff/1/runtime/lib/array_patc...
File runtime/lib/array_patch.dart (right):

https://chromiumcodereview.appspot.com/10878077/diff/1/runtime/lib/array_patc...
runtime/lib/array_patch.dart:1: // Copyright (c) 2012, the Dart project authors.
 Please see the AUTHORS file
Is this the time to start calling them list, e.g. list_patch.dart?

[Mads Ager (google), 2012-08-27 14:02:42]

LGTM

https://chromiumcodereview.appspot.com/10878077/diff/1/corelib/src/implementa...
File corelib/src/implementation/list.dart (right):

https://chromiumcodereview.appspot.com/10878077/diff/1/corelib/src/implementa...
corelib/src/implementation/list.dart:24: // TODO(ajohnsen): Make external once
the vm can handle it, so we don't
On 2012/08/27 13:56:45, ajohnsen wrote:
> Should I file a bug and add issue number here?

Yes, please. Bug report that named factory constructors do not work would be
good.

https://chromiumcodereview.appspot.com/10878077/diff/1/corelib/src/implementa...
corelib/src/implementation/list.dart:25: //                 lose generic type
information.
But please lose the additional indentation here. Don't align this with :

https://chromiumcodereview.appspot.com/10878077/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/mockimpl.dart (right):

https://chromiumcodereview.appspot.com/10878077/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mockimpl.dart:15: class StringBase {
You should move StringBase to a real file as well. Then only ReceivePortFactory
is left here. We should look into getting rid of that too so we can get rid of
the mockimpl file.

https://chromiumcodereview.appspot.com/10878077/diff/1/runtime/lib/array_patc...
File runtime/lib/array_patch.dart (right):

https://chromiumcodereview.appspot.com/10878077/diff/1/runtime/lib/array_patc...
runtime/lib/array_patch.dart:1: // Copyright (c) 2012, the Dart project authors.
 Please see the AUTHORS file
On 2012/08/27 13:56:45, ajohnsen wrote:
> Is this the time to start calling them list, e.g. list_patch.dart?

Let's do a cleanup sweep to do that?

[Anders Johnsen, 2012-08-27 14:05:39]

Thank you, landing!

https://chromiumcodereview.appspot.com/10878077/diff/1/corelib/src/implementa...
File corelib/src/implementation/list.dart (right):

https://chromiumcodereview.appspot.com/10878077/diff/1/corelib/src/implementa...
corelib/src/implementation/list.dart:24: // TODO(ajohnsen): Make external once
the vm can handle it, so we don't
On 2012/08/27 14:02:42, Mads Ager wrote:
> On 2012/08/27 13:56:45, ajohnsen wrote:
> > Should I file a bug and add issue number here?
> 
> Yes, please. Bug report that named factory constructors do not work would be
> good.

Done.

https://chromiumcodereview.appspot.com/10878077/diff/1/corelib/src/implementa...
corelib/src/implementation/list.dart:25: //                 lose generic type
information.
On 2012/08/27 14:02:42, Mads Ager wrote:
> But please lose the additional indentation here. Don't align this with :

Done.

https://chromiumcodereview.appspot.com/10878077/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/mockimpl.dart (right):

https://chromiumcodereview.appspot.com/10878077/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mockimpl.dart:15: class StringBase {
On 2012/08/27 14:02:42, Mads Ager wrote:
> You should move StringBase to a real file as well. Then only
ReceivePortFactory
> is left here. We should look into getting rid of that too so we can get rid of
> the mockimpl file.

Right, will do in a follow-up CL.

https://chromiumcodereview.appspot.com/10878077/diff/1/runtime/lib/array_patc...
File runtime/lib/array_patch.dart (right):

https://chromiumcodereview.appspot.com/10878077/diff/1/runtime/lib/array_patc...
runtime/lib/array_patch.dart:1: // Copyright (c) 2012, the Dart project authors.
 Please see the AUTHORS file
On 2012/08/27 14:02:42, Mads Ager wrote:
> On 2012/08/27 13:56:45, ajohnsen wrote:
> > Is this the time to start calling them list, e.g. list_patch.dart?
> 
> Let's do a cleanup sweep to do that?

Roger!