Issue 10878059: Add a missing semicolon to a file in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10878059: Add a missing semicolon to a file in pub. (Closed)

Created:
8 years, 4 months ago by nweiz

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a missing semicolon to a file in pub. Committed: https://code.google.com/p/dart/source/detail?r=11342

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	utils/pub/source.dart	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://chromiumcodereview.appspot.com/10878059/diff/1/utils/pub/source.dart File utils/pub/source.dart (right): https://chromiumcodereview.appspot.com/10878059/diff/1/utils/pub/source.dart#newcode111 utils/pub/source.dart:111: "source $name."; Indent +2.

8 years, 4 months ago (2012-08-24 20:57:33 UTC) #2

nweiz

8 years, 4 months ago (2012-08-24 21:01:42 UTC) #3

https://chromiumcodereview.appspot.com/10878059/diff/1/utils/pub/source.dart
File utils/pub/source.dart (right):

https://chromiumcodereview.appspot.com/10878059/diff/1/utils/pub/source.dart#...
utils/pub/source.dart:111: "source $name.";
On 2012/08/24 20:57:33, Bob Nystrom wrote:
> Indent +2.

Done.

Expand Messages | Collapse Messages