Unify Object implementation across dart2js and VM.

Unify Object implementation across dart2js and VM.

R=ajohnsen@google.com,lrn@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11372

[Mads Ager (google), 2012-08-24 12:44:32]

https://chromiumcodereview.appspot.com/10878050/diff/1/tests/co19/co19-dart2j...
File tests/co19/co19-dart2js.status (left):

https://chromiumcodereview.appspot.com/10878050/diff/1/tests/co19/co19-dart2j...
tests/co19/co19-dart2js.status:185: Language/10_Expressions/20_Equality_A03_t02:
Fail # Compile-time error: unexpected token 'equals'
The code that used to cause the compile-time error is now dead code and not
compiled.

[Anders Johnsen, 2012-08-24 12:55:29]

LGTM, very nice and clean.

One question: Would it make sense to actually have a patch for core, that would
implement this StringImplementation? I'm not sure if I like this idea at all,
but it might be the way to also patch 'print'.

[Mads Ager (google), 2012-08-24 13:35:27]

On 2012/08/24 12:55:29, ajohnsen wrote:
> LGTM, very nice and clean.
> 
> One question: Would it make sense to actually have a patch for core, that
would
> implement this StringImplementation? I'm not sure if I like this idea at all,
> but it might be the way to also patch 'print'.

That might make sense. 'print' is more complicated than it looks though because
there is another layer of patching going on in the VM alone through the builtins
library. This extra layer allows the embedder to supply the 'print' function.
The 'print' function supplied by Dartium puts the strings in the Chrome console.

[Ivan Posva, 2012-08-27 20:11:40]

DBC -ip

https://chromiumcodereview.appspot.com/10878050/diff/1/corelib/src/object.dart
File corelib/src/object.dart (right):

https://chromiumcodereview.appspot.com/10878050/diff/1/corelib/src/object.dar...
corelib/src/object.dart:11: String toString() =>
ObjectImplementation.toStringImpl(this);
Why isn't this "external String toString();"?

https://chromiumcodereview.appspot.com/10878050/diff/1/corelib/src/object.dar...
corelib/src/object.dart:13: void noSuchMethod(String name, List args) {
ditto

[Lasse Reichstein Nielsen, 2012-08-27 20:48:49]

https://chromiumcodereview.appspot.com/10878050/diff/1/corelib/src/object.dart
File corelib/src/object.dart (right):

https://chromiumcodereview.appspot.com/10878050/diff/1/corelib/src/object.dar...
corelib/src/object.dart:11: String toString() =>
ObjectImplementation.toStringImpl(this);
Agree. Seems like a wasted indirection.

https://chromiumcodereview.appspot.com/10878050/diff/1/corelib/src/object.dar...
corelib/src/object.dart:17: operator ==(other) => this === other;
return type 'bool'.

[Ivan Posva, 2012-08-27 21:09:52]

https://chromiumcodereview.appspot.com/10878050/diff/1/runtime/lib/lib_source...
File runtime/lib/lib_sources.gypi (right):

https://chromiumcodereview.appspot.com/10878050/diff/1/runtime/lib/lib_source...
runtime/lib/lib_sources.gypi:17: 'weak_property.cc',
This change aded back weak_property.cc and weak_property.dart to
lib_sources.gypi. Why is this not visible here in the code review?

[Mads Ager (google), 2012-08-28 06:03:38]

It is indirected to go through coreimpl so I didn't have to patch core. We can
do it the other way too and I'll be happy to do that later. This is consistent
with the way things have been done here so far (not making any judgement on
that, just trying to unify without rocking the boat too much).

The addition of weak_property was a merge error. Sorry about that.